npawar commented on pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#issuecomment-670244811
> Well done. > Most comments are minor (comments in `OfflineSegmentAssignment` also applies to `RealtimeSegmentAssignment`). > Please merge the 2 relocators into one. Thanks for the review. I've merged the 2 relocators into `SegmentRelocator`. I introduced controller confs for `controller.segment.relocator.frequency`, and deprecated the confs for `.controller.realtime.segment.relocator.frequency`. For some releases, we'll carry both around. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
