npawar commented on pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#issuecomment-670999241
> > Made one small change not part of the review. Converted the "segmentSelectorType" and "storageType" to enums. If you want to look again. > > Since we introduced the enum, try to use enum over string for these 2 fields The reason I kept it string is that if we want people to plug in their own strategies, they can do so without needing to add it to the enum ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
