npawar commented on a change in pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#discussion_r466742315
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java ########## @@ -91,6 +104,17 @@ public void init(HelixManager helixManager, TableConfig tableConfig) { } } + /** + * Returns a sorted list of Tiers from the TierConfigList in table config. + * Keeps only those which have "pinotServer" storage type. + */ + @VisibleForTesting + protected List<Tier> getSortedTiersForPinotServerStorage(List<TierConfig> tierConfigList) { + return tierConfigList.stream().filter(t -> TierFactory.PINOT_SERVER_STORAGE_TYPE.equals(t.getStorageType())) Review comment: Moved to TierConfigUtils, and removed lambdas ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org