siddharthteotia commented on a change in pull request #5625:
URL: https://github.com/apache/incubator-pinot/pull/5625#discussion_r448680805
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/reader/impl/FixedByteChunkSVForwardIndexReader.java
##########
@@ -16,123 +16,117 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.core.io.reader.impl.v1;
+package org.apache.pinot.core.io.reader.impl;
import java.io.IOException;
import java.nio.ByteBuffer;
-import org.apache.pinot.core.io.reader.impl.ChunkReaderContext;
-import org.apache.pinot.core.io.writer.impl.v1.FixedByteChunkSingleValueWriter;
+import org.apache.pinot.core.io.writer.impl.FixedByteChunkSVForwardIndexWriter;
import org.apache.pinot.core.segment.memory.PinotDataBuffer;
+import org.apache.pinot.spi.data.FieldSpec.DataType;
/**
- * Reader class for data written out by {@link
FixedByteChunkSingleValueWriter}.
- * For data layout, please refer to the documentation for {@link
FixedByteChunkSingleValueReader}
+ * Reader class for data written out by {@link
FixedByteChunkSVForwardIndexWriter}.
Review comment:
For completeness, let's also say raw forward index reader in the javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
