Jackie-Jiang commented on a change in pull request #5625:
URL: https://github.com/apache/incubator-pinot/pull/5625#discussion_r449248316



##########
File path: 
pinot-core/src/test/java/org/apache/pinot/index/readerwriter/FixedByteChunkSVForwardIndexReaderWriterTest.java
##########
@@ -276,56 +257,6 @@ public void 
testDouble(ChunkCompressorFactory.CompressionType compressionType)
     FileUtils.deleteQuietly(outFileEightByte);
   }
 
-  public void testBytes(ChunkCompressorFactory.CompressionType compressionType)

Review comment:
       It can be supported, but is never used. STRING and BYTES are always 
handled as var-bytes (we don't have the metadata to denote whether a column is 
fixed-bytes or var-bytes).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to