Jackie-Jiang commented on a change in pull request #5625:
URL: https://github.com/apache/incubator-pinot/pull/5625#discussion_r447274712
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/readerwriter/ForwardIndexReaderWriter.java
##########
@@ -16,11 +16,29 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.core.io.reader.impl;
+package org.apache.pinot.core.io.readerwriter;
+import org.apache.pinot.core.io.reader.ForwardIndexReader;
import org.apache.pinot.core.io.reader.ReaderContext;
+import org.apache.pinot.core.io.writer.ForwardIndexWriter;
-public class UnSortedValueReaderContext implements ReaderContext {
+/**
+ * Interface for forward index reader-writer.
+ */
+public interface ForwardIndexReaderWriter extends
ForwardIndexReader<ReaderContext>, ForwardIndexWriter {
Review comment:
1. Somehow git identifies them as a move. It is supposed to replace
`BaseSingleColumnSingleValueReaderWriter` and
`BaseSingleColumnMultiValueReaderWriter`
2. It extends `ForwardIndexReader` and `ForwardIndexWriter` which contains
all the read and write api's
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
