Jackie-Jiang commented on a change in pull request #5625: URL: https://github.com/apache/incubator-pinot/pull/5625#discussion_r447268389
########## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ColumnValueReader.java ########## @@ -0,0 +1,248 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.common; + +import org.apache.pinot.core.io.reader.ForwardIndexReader; +import org.apache.pinot.core.io.reader.ReaderContext; +import org.apache.pinot.spi.data.FieldSpec.DataType; + + +/** + * ColumnValueReader is a wrapper class on top of the forward index reader to read values from it. + * <p>Batch value read APIs support the following data type conversions for numeric types: + * <ul> + * <li>INT -> LONG</li> + * <li>INT, LONG -> FLOAT</li> + * <li>INT, LONG, FLOAT -> DOUBLE</li> + * </ul> + */ +@SuppressWarnings({"rawtypes", "unchecked"}) +public final class ColumnValueReader { + private final ForwardIndexReader _forwardIndexReader; + private final DataType _valueType; + private final ReaderContext _readerContext; + + public ColumnValueReader(ForwardIndexReader forwardIndexReader) { + _forwardIndexReader = forwardIndexReader; + _valueType = forwardIndexReader.getValueType(); + // TODO: Figure out a way to close the reader context. Currently it can cause direct memory leak. Review comment: This is the current behavior. The fix is not very straight forward, so I don't want to mix this fix with the refactor PR. Will try to fix it in the next PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
