Jackie-Jiang commented on a change in pull request #5625:
URL: https://github.com/apache/incubator-pinot/pull/5625#discussion_r449245551
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/InvertedIndexReader.java
##########
@@ -24,13 +24,14 @@
public interface InvertedIndexReader<T> extends Closeable {
/**
- * Get the document ids for the given dictionary id.
- * @param dictId dictionary ID
+ * Returns the document ids for the given dictionary id.
*/
T getDocIds(int dictId);
/**
- * Get the document ids for a given value
+ * Returns the document ids for the given string representation of the value.
Review comment:
The value here is from the query, so we always pass it in as string, and
the inverted index implementation can parse the string based on the value type.
This is similar to how dictionary handles the lookup of user input value
(`Dictionary.indexOf(String stringValue)`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
