9aman commented on code in PR #16071:
URL: https://github.com/apache/pinot/pull/16071#discussion_r2174273848
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1472,9 +1472,10 @@ public void goOnlineFromConsuming(SegmentZKMetadata
segmentZKMetadata)
} else if (_currentOffset.compareTo(endOffset) == 0) {
_segmentLogger
.info("Current offset {} matches offset in zk {}.
Replacing segment", _currentOffset, endOffset);
- boolean replaced = buildSegmentAndReplace();
Review Comment:
I see two scenarios:
1. Issue with the segment e.g. incorrect data:
- In this case the re-ingestion will fail as well.
- Deleting the segment and switching to latest offset will be the way
forward.
2. Issue on the server e.g. out of disk/ memory:
- In this case both of the above scenarios i.e. build and
downloadSegmentAndReplace might end up failing.
Also, have we come across this scenario in past ?
cc: @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
