noob-se7en commented on code in PR #16071:
URL: https://github.com/apache/pinot/pull/16071#discussion_r2175867585
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/StreamIngestionConfig.java:
##########
@@ -54,6 +55,10 @@ public class StreamIngestionConfig extends BaseJsonConfig {
@JsonPropertyDescription("Policy to determine the behaviour of parallel
consumption.")
private ParallelSegmentConsumptionPolicy _parallelSegmentConsumptionPolicy;
+ @JsonPropertyDescription("Recovery mode which is used to decide how to
recover a segment online in IS but having no"
+ + " completed (immutable) replica on any server in pause-less ingestion")
+ private DisasterRecoveryMode _disasterRecoveryMode =
DisasterRecoveryMode.ALWAYS;
Review Comment:
On second thought, no, since data correctness makes sense in default mode.
Thanks, changed to `DEFAULT` which is skip upsert/dedup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
