noob-se7en commented on code in PR #16071:
URL: https://github.com/apache/pinot/pull/16071#discussion_r2143580884
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1472,9 +1472,10 @@ public void goOnlineFromConsuming(SegmentZKMetadata
segmentZKMetadata)
} else if (_currentOffset.compareTo(endOffset) == 0) {
_segmentLogger
.info("Current offset {} matches offset in zk {}.
Replacing segment", _currentOffset, endOffset);
- boolean replaced = buildSegmentAndReplace();
Review Comment:
These changes are required because incase of segment buildfailure,
reingestion happens. Let's say during reingestion server is successful in
uploading the segment, but when offline -> online is triggered during reset of
the segment build can still fail on servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
