Jackie-Jiang commented on code in PR #16071:
URL: https://github.com/apache/pinot/pull/16071#discussion_r2165133300
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ReplicaGroupStrategyConfig.java:
##########
@@ -27,7 +27,9 @@
/**
* Class representing configurations related to segment assignment strategy.
+ * @deprecated Use {@link
org.apache.pinot.spi.config.table.assignment.InstanceAssignmentConfig} instead.
*/
+@Deprecated
Review Comment:
We cannot fully deprecate this config yet because `partitionColumn` can only
be configured here when we are using `instancePartitionsMap`. I'd suggest not
deprecating it in this PR (as it is a different scope) and addressing it in a
separate PR
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/DisasterRecoveryMode.java:
##########
@@ -0,0 +1,24 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.config.table;
+
+public enum DisasterRecoveryMode {
+ BEST_EFFORT
+ // TODO: Add support for strict recovery mode.
Review Comment:
Suggest adding STRICT in the same PR, which is the default mode when not
configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
