Jackie-Jiang commented on code in PR #16071: URL: https://github.com/apache/pinot/pull/16071#discussion_r2175809470
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/DisasterRecoveryMode.java: ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table; + +/** + Recovery mode which is used to decide how to recover a segment online in IS but having no completed (immutable) + replica on any server in pause-less ingestion + */ +public enum DisasterRecoveryMode { + // ALWAYS means Pinot will always run the Disaster Recovery Job + ALWAYS, + // CONSISTENCY_FIRST means Pinot will skip the Disaster Recovery Job for tables like dedup/upsert where consistency + // of data is higher in priority than availability. + CONSISTENCY_FIRST Review Comment: We can call this `DEFAULT`, and use javadoc to explain its behavior ########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/StreamIngestionConfig.java: ########## @@ -54,6 +55,10 @@ public class StreamIngestionConfig extends BaseJsonConfig { @JsonPropertyDescription("Policy to determine the behaviour of parallel consumption.") private ParallelSegmentConsumptionPolicy _parallelSegmentConsumptionPolicy; + @JsonPropertyDescription("Recovery mode which is used to decide how to recover a segment online in IS but having no" + + " completed (immutable) replica on any server in pause-less ingestion") + private DisasterRecoveryMode _disasterRecoveryMode = DisasterRecoveryMode.ALWAYS; Review Comment: This is a behavior change. Do we want to keep the existing behavior? ########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/DisasterRecoveryMode.java: ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table; + +/** + Recovery mode which is used to decide how to recover a segment online in IS but having no completed (immutable) + replica on any server in pause-less ingestion + */ Review Comment: (minor) Follow javadoc convention ```suggestion /** * Recovery mode which is used to decide how to recover a segment online in IS but having no completed (immutable) * replica on any server in pause-less ingestion */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
