yashmayya commented on PR #15571: URL: https://github.com/apache/pinot/pull/15571#issuecomment-2840906511
> This PR creates a new splitting strategy on top of that based purely on the block bytes payload. Both strategies can live simultaneously, although it is expected that byte-based splitter will take over and row-based splitter can be eventually removed. @gortiz the `BlockSplitter` used in `BlockExchange` to split blocks based on rows doesn't serve any other purpose than trying to keep the gRPC message size under the max limit right? Any reason we can't get rid of that with this new strategy immediately? I'm not sure if I'm missing anything but it seems like unnecessary overhead now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
