gortiz commented on PR #15571: URL: https://github.com/apache/pinot/pull/15571#issuecomment-2840947479
> the BlockSplitter used in BlockExchange to split blocks based on rows doesn't serve any other purpose than trying to keep the gRPC message size under the max limit right? Any reason we can't get rid of that with this new strategy immediately? I'm not sure if I'm missing anything but it seems like unnecessary overhead now? Good catch. It is pretty useless and the plan is to remove it in the future. But we decided to keep it for now to not affect upgrades. I mean, during an upgrade updated servers will split with BlockSplitter to make sure not upgraded servers do not receive blocks that are larger than they use to be. @albertobastos this reminds me that one thing we forgot is to add the flag that enables/disables this feature. We need to disable wait for more (always send complete blocks) during an upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
