albertobastos commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2068026931
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/mailbox/MailboxServiceTest.java:
##########
@@ -87,7 +87,7 @@ public void testLocalHappyPathSendFirst()
SendingMailbox sendingMailbox =
_mailboxService1.getSendingMailbox("localhost",
_mailboxService1.getPort(), mailboxId, Long.MAX_VALUE, _stats);
for (int i = 0; i < ReceivingMailbox.DEFAULT_MAX_PENDING_BLOCKS - 1; i++) {
- sendingMailbox.send(OperatorTestUtil.block(DATA_SCHEMA, new
Object[]{i}));
+ sendingMailbox.send(OperatorTestUtil.block(DATA_SCHEMA, new
Object[]{Integer.toString(i)}));
Review Comment:
In `testRemoteBufferFull` we need to be sure about the payload size to avoid
splitting, and that's easier when using strings instead of ints in the schema.
So we changed the `DATA_SCHEMA` constant to be `{STRING}` instead of `{INT}`.
Doing that, we need to change the rest of tests to fill the block with strings
instead of ints to avoid casting errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
