yashmayya commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2067962738
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlockUtils.java:
##########
@@ -252,7 +252,7 @@ public static DataBlock readFrom(ByteBuffer buffer)
public static DataBlock deserialize(List<ByteBuffer> buffers)
throws IOException {
List<DataBuffer> dataBuffers = buffers.stream()
- .map(PinotByteBuffer::wrap)
+ .map(PinotByteBuffer::slice)
Review Comment:
Ah, thanks for that clarification, I was checking non-testing code only and
wasn't able to find any scenarios where the position / limit would be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
