gortiz commented on code in PR #15571: URL: https://github.com/apache/pinot/pull/15571#discussion_r2058295221
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java: ########## @@ -58,10 +61,18 @@ public void onNext(MailboxContent mailboxContent) { if (_mailbox == null) { _mailbox = _mailboxService.getReceivingMailbox(mailboxId); } + if (_mailboxBuffers == null) { + _mailboxBuffers = new ArrayList<>(); + } Review Comment: tip: ArrayLists do not allocate the array on construction unless you specify a custom size (see https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/19fb8f93c59dfd791f62d41f332db9e306bc1422/src/java.base/share/classes/java/util/ArrayList.java#L166) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org