itschrispeck commented on code in PR #15139:
URL: https://github.com/apache/pinot/pull/15139#discussion_r1972677661
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/SVScanDocIdIterator.java:
##########
@@ -138,6 +138,7 @@ public MutableRoaringBitmap applyAnd(BatchIterator
docIdIterator, OptionalInt fi
}
_numEntriesScanned += limit;
}
+ close();
Review Comment:
This makes an assumption that applyAnd will not be called multiple times, or
after EOF has been returned by `next`/`advance` - but I don't think this
contract is explicitly defined (yet? I can add a comment in the interface)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
