itschrispeck commented on code in PR #15139:
URL: https://github.com/apache/pinot/pull/15139#discussion_r1987860220
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java:
##########
@@ -445,6 +444,7 @@ private void decompressViaDirectBuffer(ByteBuffer
compressed, byte[] target)
@Override
public void close() {
CleanerUtil.cleanQuietly(_decompressedBuffer);
+ _decompressedBuffer = null;
Review Comment:
Nope, had seen some blogs mention it is required so a/b tested it, and it is
not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
