abhishekbafna commented on PR #14844: URL: https://github.com/apache/pinot/pull/14844#issuecomment-2674013224
> I don't see the change in `org.apache.pinot.segment.local.utils.TableConfigUtils`. That is needed for the ingestion groovy validation The ingestion (table create and update) path is already covered as part of the `TableConfigUtils#validateIngestionConfig` when `GroovyFunctionEvaluator` object is initialized, the parsing and validation happens. This happens when `FunctionEvaluatorFactory.getExpressionEvaluator(filterFunction)` is called in the validate ingestion config method. I attached a screenshot as well earlier show the same. <img width="1686" alt="Screenshot 2025-02-12 at 10 33 51 AM" src="https://github.com/user-attachments/assets/583a4790-ce2c-4eeb-b57b-38bed210f558"; /> <img width="678" alt="Controller Table API Call Stack" src="https://github.com/user-attachments/assets/23305a3b-a449-471a-94a9-5745aaf97261"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
