abhishekbafna commented on code in PR #14844:
URL: https://github.com/apache/pinot/pull/14844#discussion_r1965137365


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -29,6 +29,8 @@
 
 
 public class CommonConstants {
+  public static final String GROOVY_STATIC_ANALYZER_CONFIG = 
"pinot.server.groovy.static.analyzer";

Review Comment:
   OKay. As a single configuration, it was added at the top level. I will 
create separate configuration for controller (ingestion) and broker (query).
   
   For ingestion, under Controller subclass: 
`pinot.ingestion.groovy.static.analyzer`
   For query, under Broker subclass: `pinot.query.groovy.static.analyzer`
   Common configuration, as top level config in the CommonConstants class: 
`pinot.groovy.static.analyzer`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to