abhishekbafna commented on PR #14844: URL: https://github.com/apache/pinot/pull/14844#issuecomment-2686987484
> @abhishekbafna > > > one thing to note is, the controller config would be applied on the table update and creation. It would not apply on any existing ingestion config. For that it need to be init the config in minion and other external jobs (hadoop, spark etc). > > That should be fine. We want to guard the new table config posted. The same logic applies to `disableGroovy` check as well. > > Can you rebase the change? I think the test failures are irrelavant. Done. Also did some minor code refactoring to avoid the unnecessary string double quotes while converting to json format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
