abhishekbafna commented on PR #14844: URL: https://github.com/apache/pinot/pull/14844#issuecomment-2671142540
> Currently we apply groovy check in 2 places: > > 1. In `TableConfigUtils` (see the usage of `_disableGroovy` field) > 2. In `BaseSingleStageBrokerRequestHandler` (see the usage of `_disableGroovy` field) > > Can we apply the static analysis at the same place? Applying it during ingestion/query execution might already be too late. Now the static analysis for both ingestion and query is applied along with the disableGroovy checks. For the ingestion, it happens in the `TableConfigUtils#validateIngestionConfig` when `FunctionEvaluatorFactory.getExpressionEvaluator(filterFunction)` is called for the groovy scripts. For the query, added a new method `groovySecureAnalysis` that would execute when groovy is enabled. Any changes to the configuration would require restart of the broker nodes. <img width="1685" alt="Screenshot 2025-02-20 at 4 01 16 PM" src="https://github.com/user-attachments/assets/6d5dc4e6-5d3f-4fc2-8afb-93b8af3271f2"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
