Jackie-Jiang commented on code in PR #14844:
URL: https://github.com/apache/pinot/pull/14844#discussion_r1964989455
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -515,9 +516,7 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
}
HandlerContext handlerContext = getHandlerContext(offlineTableConfig,
realtimeTableConfig);
- if (handlerContext._disableGroovy) {
- rejectGroovyQuery(serverPinotQuery);
- }
+ rejectGroovyQuery(serverPinotQuery, handlerContext._disableGroovy);
Review Comment:
Suggest renaming it to `validateGroovy`
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -29,6 +29,8 @@
public class CommonConstants {
+ public static final String GROOVY_STATIC_ANALYZER_CONFIG =
"pinot.server.groovy.static.analyzer";
Review Comment:
This shouldn't be added as top level config. We need this config for both
controller and broker, and they can potentially be different (one is for
ingestion, and one is for query). Take a look at the subclass `Controller` and
`Broker` within this class.
We can also consider adding a common one to be used when there is no
controller/broker specific config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
