Jackie-Jiang commented on code in PR #15078:
URL: https://github.com/apache/pinot/pull/15078#discussion_r1960454941
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -146,6 +146,7 @@ public abstract class BaseSingleStageBrokerRequestHandler
extends BaseBrokerRequ
// if >= 0, then overrides default limit of 10, otherwise setting is ignored
protected final int _defaultQueryLimit;
protected final boolean _enableMultistageMigrationMetric;
+ protected final boolean _useMSQEWhenEmptySchema;
Review Comment:
(minor) Suggest keeping the names consistent
```suggestion
protected final boolean _useMSQEToFillEmptyResponseSchema;
```
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -584,6 +584,10 @@ public static class QueryOptionKey {
// Custom Query ID provided by the client
public static final String CLIENT_QUERY_ID = "clientQueryId";
+
+ // Use MSQE compiler when trying to fill a response with no schema
metadata
+ // (overrides the "pinot.broker.use.msqe.schema" broker conf)
+ public static final String USE_MSQE_EMPTY_SCHEMA =
"useMsqeWhenEmptySchema";
Review Comment:
Seems this one is missing. Please also update the method name in
`QueryOptionsUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
