Jackie-Jiang commented on code in PR #15078:
URL: https://github.com/apache/pinot/pull/15078#discussion_r1958766725
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -584,6 +584,10 @@ public static class QueryOptionKey {
// Custom Query ID provided by the client
public static final String CLIENT_QUERY_ID = "clientQueryId";
+
+ // Use MSQE compiler when trying to fill a response with no schema
metadata
+ // (overrides the "pinot.broker.use.msqe.schema" broker conf)
+ public static final String USE_MSQE_EMPTY_SCHEMA =
"useMsqeWhenEmptySchema";
Review Comment:
```suggestion
public static final String USE_MSQE_TO_FILL_EMPTY_RESPONSE_SCHEMA =
"useMsqeToFillEmptyResponseSchema";
```
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -904,6 +909,18 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
return brokerResponse;
}
+ /**
+ * Determines if MSQE can be used to try to fill an empty schema response.
+ */
+ private boolean useMSQEToFillEmptySchema(@Nullable PinotQuery pinotQuery) {
Review Comment:
Will `pinotQuery` ever be `null`?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -704,6 +708,9 @@ public enum Type {
}
public static final String PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY =
"pinot.broker.storage.factory";
+
Review Comment:
Suggest something more specific:
`pinot.broker.use.msqe.to.fill.empty.response.schema`
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -904,6 +909,18 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
return brokerResponse;
}
+ /**
+ * Determines if MSQE can be used to try to fill an empty schema response.
+ */
+ private boolean useMSQEToFillEmptySchema(@Nullable PinotQuery pinotQuery) {
Review Comment:
You may put this logic into `QueryOptionsUtils`, similar to
`isUseFixedReplica()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
