albertobastos commented on code in PR #15078:
URL: https://github.com/apache/pinot/pull/15078#discussion_r1958569209
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -869,7 +873,9 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
// server returns STRING as default dataType for all columns in (some)
scenarios where no rows are returned
// this is an attempt to return more faithful information based on other
sources
if (brokerResponse.getNumRowsResultSet() == 0) {
Review Comment:
You're right, I rushed it and the expected behavior is as you described.
578fea9546
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -704,6 +708,9 @@ public enum Type {
}
public static final String PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY =
"pinot.broker.storage.factory";
+
Review Comment:
Yep, the dots approach seems to be the common one.
Changed to `pinot.broker.use.msqe.schema`
578fea9546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
