bziobrowski commented on code in PR #15078: URL: https://github.com/apache/pinot/pull/15078#discussion_r1958398359
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -704,6 +708,9 @@ public enum Type { } public static final String PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY = "pinot.broker.storage.factory"; + Review Comment: nit: setting key is a bit unusual. It seems `pinto.broker.camelCaseSuffix` or `pinot.broker.dot.between.every.word` is more common. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org