bziobrowski commented on code in PR #15078:
URL: https://github.com/apache/pinot/pull/15078#discussion_r1958393203
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -869,7 +873,9 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
// server returns STRING as default dataType for all columns in (some)
scenarios where no rows are returned
// this is an attempt to return more faithful information based on other
sources
if (brokerResponse.getNumRowsResultSet() == 0) {
Review Comment:
Shouldn't query option override default ?
With current implementation it doesn't seem possible to override
`_useMSQEWhenEmptySchema=true` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
