FANNG1 commented on code in PR #10517:
URL: https://github.com/apache/gravitino/pull/10517#discussion_r3148212321
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/jdbc/GravitinoJdbcCatalogFactoryOptions.java:
##########
@@ -30,6 +30,20 @@ public class GravitinoJdbcCatalogFactoryOptions {
/** Identifier for the {@link GravitinoJdbcCatalog}. */
public static final String POSTGRESQL_IDENTIFIER =
"gravitino-jdbc-postgresql";
+ public static final ConfigOption<String> BASE_URL =
+
ConfigOptions.key(JdbcPropertiesConstants.FLINK_JDBC_URL).stringType().noDefaultValue();
+
+ public static final ConfigOption<String> USERNAME =
+
ConfigOptions.key(JdbcPropertiesConstants.FLINK_JDBC_USER).stringType().noDefaultValue();
+
+ public static final ConfigOption<String> PASSWORD =
+
ConfigOptions.key(JdbcPropertiesConstants.FLINK_JDBC_PASSWORD).stringType().noDefaultValue();
+
public static final ConfigOption<String> DEFAULT_DATABASE =
- ConfigOptions.key("default-database").stringType().noDefaultValue();
+ ConfigOptions.key(JdbcPropertiesConstants.FLINK_JDBC_DEFAULT_DATABASE)
+ .stringType()
+ .noDefaultValue();
+
+ public static final ConfigOption<String> DRIVER =
+
ConfigOptions.key(JdbcPropertiesConstants.FLINK_DRIVER).stringType().noDefaultValue();
}
Review Comment:
Follow-up: I changed this after the later review round. The current code no
longer keeps the extra JDBC Flink-side options here;
`GravitinoJdbcCatalogFactoryOptions` is back to only `DEFAULT_DATABASE`, and
the common JDBC factory no longer widens the required/optional option contract.
That keeps this PR aligned with the spec goal of staying behavior-preserving
during the initial versioned split.
##########
settings.gradle.kts:
##########
@@ -82,8 +82,11 @@ include(
include("spark-connector:spark-common")
if (scalaVersion == "2.12") {
// flink only support scala 2.12
- include("flink-connector:flink")
- include("flink-connector:flink-runtime")
+ include("flink-connector:flink-common")
+ include("flink-connector:flink-1.18", "flink-connector:flink-runtime-1.18")
Review Comment:
Agreed. This was a real miss in the workflow exclusions after the module
split. I updated the remaining CI excludes to use the new versioned Flink
module paths:
- `:flink-connector:flink-common`
- `:flink-connector:flink-1.18`
- `:flink-connector:flink-runtime-1.18`
Specifically, I fixed
`.github/workflows/backend-integration-test-action.yml`,
`.github/workflows/trino-integration-test.yml`, and
`.github/workflows/trino-multi-version-test.yml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
