yuqi1129 commented on code in PR #10517:
URL: https://github.com/apache/gravitino/pull/10517#discussion_r3147385050
##########
settings.gradle.kts:
##########
@@ -82,8 +82,11 @@ include(
include("spark-connector:spark-common")
if (scalaVersion == "2.12") {
// flink only support scala 2.12
- include("flink-connector:flink")
- include("flink-connector:flink-runtime")
+ include("flink-connector:flink-common")
+ include("flink-connector:flink-1.18", "flink-connector:flink-runtime-1.18")
Review Comment:
This split also needs to update the CI exclusions that still reference the
removed `:flink-connector:flink` path. For example
`.github/workflows/backend-integration-test-action.yml`,
`trino-integration-test.yml`, and `trino-multi-version-test.yml` still pass `-x
:flink-connector:flink:*`; Gradle accepts those stale excludes, so those jobs
will now build/test the new Flink modules instead of skipping them as before.
Please switch those excludes to the new `:flink-connector:flink-common`,
`:flink-connector:flink-1.18`, and `:flink-connector:flink-runtime-1.18` tasks
where appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
