FANNG1 commented on code in PR #10517:
URL: https://github.com/apache/gravitino/pull/10517#discussion_r3130262127
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/jdbc/GravitinoJdbcCatalogFactory.java:
##########
@@ -51,13 +51,22 @@ public org.apache.flink.table.catalog.Catalog
createCatalog(Context context) {
Preconditions.checkArgument(
defaultDatabase != null,
GravitinoJdbcCatalogFactoryOptions.DEFAULT_DATABASE.key() + " should
not be null.");
- return new GravitinoJdbcCatalog(
+ return newCatalog(
context, defaultDatabase, schemaAndTablePropertiesConverter(),
partitionConverter());
}
+ protected Catalog newCatalog(
+ Context context,
+ String defaultDatabase,
+ SchemaAndTablePropertiesConverter schemaAndTablePropertiesConverter,
+ PartitionConverter partitionConverter) {
+ return new GravitinoJdbcCatalog(
+ context, defaultDatabase, schemaAndTablePropertiesConverter,
partitionConverter);
+ }
+
@Override
- public Catalog.Type gravitinoCatalogType() {
- return Catalog.Type.RELATIONAL;
+ public org.apache.gravitino.Catalog.Type gravitinoCatalogType() {
+ return org.apache.gravitino.Catalog.Type.RELATIONAL;
Review Comment:
I tried this change, but importing the nested `Catalog.Type` triggers Error
Prone `BadImport` with `-Werror`; the compiler explicitly recommends keeping
`org.apache.gravitino.Catalog.Type` qualified here. Since this file also
imports Flink `Catalog`, I kept the qualified Gravitino type to avoid ambiguity
and keep the build green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
