Copilot commented on code in PR #10517:
URL: https://github.com/apache/gravitino/pull/10517#discussion_r3146405119
##########
settings.gradle.kts:
##########
@@ -82,8 +82,11 @@ include(
include("spark-connector:spark-common")
if (scalaVersion == "2.12") {
// flink only support scala 2.12
- include("flink-connector:flink")
- include("flink-connector:flink-runtime")
+ include("flink-connector:flink-common")
+ include("flink-connector:flink-1.18", "flink-connector:flink-runtime-1.18")
+ project(":flink-connector:flink-1.18").projectDir =
file("flink-connector/v1.18/flink")
+ project(":flink-connector:flink-runtime-1.18").projectDir =
+ file("flink-connector/v1.18/flink-runtime")
Review Comment:
After renaming/splitting the Flink connector modules (removing
`:flink-connector:flink`), the repo still contains CI workflows referencing the
old Gradle task paths (e.g., `-x :flink-connector:flink:test` / `-x
:flink-connector:flink:build`). Those invocations will fail now that the
project is no longer included; update the remaining workflows/scripts to point
at the new `:flink-connector:flink-1.18` (and/or `flink-common`) tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
