FANNG1 commented on code in PR #10517:
URL: https://github.com/apache/gravitino/pull/10517#discussion_r3130274862
##########
flink-connector/v1.18/flink-runtime/build.gradle.kts:
##########
@@ -29,14 +29,8 @@ repositories {
mavenCentral()
}
-val flinkVersion: String = libs.versions.flink.get()
+val flinkVersion: String = libs.versions.flink18.get()
val flinkMajorVersion: String = flinkVersion.substringBeforeLast(".")
-
-// The Flink only support scala 2.12, and all scala api will be removed in a
future version.
-// You can find more detail at the following issues:
-// https://issues.apache.org/jira/browse/FLINK-23986,
-// https://issues.apache.org/jira/browse/FLINK-20845,
-// https://issues.apache.org/jira/browse/FLINK-13414.
Review Comment:
I kept the runtime guard here because this module produces the final shaded
runtime jar, where the Log4j exclusion must be enforced strictly.
`flink-common` is not the runtime artifact, and it already excludes Log4j from
the dependencies it declares. I prefer not to add the same global guard there
unless we see a concrete leakage risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
