airborne12 commented on code in PR #67342:
URL: https://github.com/apache/doris/pull/67342#discussion_r3899882403
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -1283,25 +1283,23 @@ public static TInvertedIndexFileStorageFormat
analyzeInvertedIndexFileStorageFor
invertedIndexFileStorageFormat =
properties.get(PROPERTIES_INVERTED_INDEX_STORAGE_FORMAT);
properties.remove(PROPERTIES_INVERTED_INDEX_STORAGE_FORMAT);
} else {
- if (Config.inverted_index_storage_format.equalsIgnoreCase("V1")) {
- return TInvertedIndexFileStorageFormat.V1;
- } else if
(Config.inverted_index_storage_format.equalsIgnoreCase("V2")) {
+ if (Config.inverted_index_storage_format.equalsIgnoreCase("V2")) {
return TInvertedIndexFileStorageFormat.V2;
} else {
return TInvertedIndexFileStorageFormat.V3;
}
}
if (invertedIndexFileStorageFormat.equalsIgnoreCase("v1")) {
- return TInvertedIndexFileStorageFormat.V1;
+ throw new AnalysisException(
Review Comment:
Confirmed and fixed in 607f2cf5b12.
Verified locally: on a 1FE+1BE cluster built from this PR I ran the exact
CREATE TABLE from that suite and it was rejected — `errCode = 2, detailMessage
= Inverted index V1 is deprecated and no longer allowed for new index creation.
Please use inverted index V2.` So the suite would indeed fail on every
non-cloud P2 run.
Root cause is backport-specific: on master this file no longer sets V1
because #66623 removed the single-replica-load feature entirely, so it was out
of scope for #64522. branch-4.1 still has the feature, so the suite needed the
same V1 -> V2 migration as the other ~50 suites here. After the change, the
same CREATE TABLE plus an inverted-index MATCH query succeed locally.
I also swept the rest of the 4.1 suite tree for leftover
`inverted_index_storage_format = "V1"`: the only two remaining hits are
`inverted_index_p0/test_multi_analyzer_index_version.groovy` and
`ann_index_p0/create_ann_index_test.groovy`, both of which are expected-error
cases (try/catch and `test{...exception...}`) that assert V1 is refused — same
as on master, so they are intentionally left as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
