airborne12 commented on code in PR #67342:
URL: https://github.com/apache/doris/pull/67342#discussion_r3899883410
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -2816,6 +2816,13 @@ private boolean processAddIndex(CreateIndexClause
alterClause, OlapTable olapTab
AnnIndexPropertiesChecker.checkProperties(indexDef.getProperties());
}
+ if (indexDef.getIndexType() == IndexType.INVERTED
+ && olapTable.getInvertedIndexFileStorageFormat() ==
TInvertedIndexFileStorageFormat.V1) {
Review Comment:
Thanks — I checked this against master and the same code is there:
`SchemaChangeHandler` on master carries the identical exact-enum guard
(`getInvertedIndexFileStorageFormat() == TInvertedIndexFileStorageFormat.V1`),
and this PR ports it verbatim (the only local adaptation in that hunk was
keeping 4.1's `indexDef.getColumns()`, since `getColumnNames()` is master-only
drift).
So the legacy `DEFAULT` sentinel behaviour you describe is not introduced by
this backport — it exists identically on master after #64522. Changing it only
on branch-4.1 would make the two branches diverge, which is exactly what a
backport should avoid. Keeping this PR faithful to upstream; the
DEFAULT-sentinel handling is worth a separate fix on master that can then be
picked to 4.1 in the same shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
