airborne12 commented on code in PR #67342:
URL: https://github.com/apache/doris/pull/67342#discussion_r3900706295
##########
regression-test/suites/inverted_index_p0/test_compound_reader_fault_injection.groovy:
##########
@@ -35,7 +35,7 @@ suite("test_compound_reader_fault_injection",
"nonConcurrent") {
DISTRIBUTED BY HASH(`@timestamp`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
- "inverted_index_storage_format" = "V1"
+ "inverted_index_storage_format" = "V2"
Review Comment:
Checked the landed master version of this suite: it is line-for-line the
same as mine here — inverted_index_storage_format = V2 at line 38 with
construct_DorisCompoundReader_failed still enabled/asserted/disabled at lines
51/56/59. So the V1-only hook being unreachable after the V2 conversion is
exactly the upstream state, ported verbatim.
Adding a V2-reachable reader hook is a valid follow-up, but doing it only on
4.1 would diverge the suite from master. Keeping this PR faithful to #64522.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
