airborne12 opened a new pull request, #67342:
URL: https://github.com/apache/doris/pull/67342
### What problem does this PR solve?
Issue Number: N/A
Related PR: #64522 (master), picked from commit
d1070cb002ecb78af59a190bab49f8679b8841e9
Problem Summary:
Backport of #64522 to branch-4.1. When users copy historical DDL that
explicitly sets inverted index format to V1, new tables are silently created
with V1. V1 lacks small-file merging and bypasses the packed file path,
significantly amplifying PUT requests to object storage. This change blocks new
inverted index V1 creation at FE (CREATE TABLE / CREATE INDEX / ALTER, and
runtime `ADMIN SET FRONTEND CONFIG`), adds a V1-deprecation regression test,
and migrates ~50 regression suites off V1.
**Hunk audit (source diff → this PR)**: 57 files total — **50 Ported
(verbatim)** (byte-identical change sets, incl. the new
`InvertedIndexStorageFormatValidator` and `test_inverted_index_v1_deprecated`),
**7 Adapted**:
| File | Adaptation |
|---|---|
| `Config.java` | 4.1 keeps the bilingual description array; merged with the
new `RuntimeConfigHandler` callback (ConfField `callback` mechanism exists in
4.1's `ConfigBase`); re-indented for checkstyle |
| `SchemaChangeHandler.java` | the +7-line V1-block check ported verbatim;
kept 4.1's `indexDef.getColumns()` (`getColumnNames()` in the conflict context
is master-only drift, not part of the source diff) |
| `test_nereids_show_build_index.groovy` / `test_nereids_show_index.groovy`
| these suites live under `nereids_p0/show/` on 4.1 (moved to `query_p0/show/`
on master); the ±2 edits landed at the 4.1 paths |
| `test_index_change_6.groovy` | adopted the PR's `nonConcurrent` tag; kept
4.1's `timeout = 60000` (master's 300000 is unrelated drift); V1 section (-83
lines) removed as in source |
| `test_index_io_context.groovy` / `test_index_multi_match.groovy` /
`var_index.groovy` | V1 tables/sections removed exactly as in source;
post-resolution V1-identifier sweep matches master's files 1:1 |
**Local verification on this branch (ASAN build)**:
- FE UT: `ConfigTest` 6/6, `PropertyAnalyzerTest` 12/12 (both actually
executed, verified in surefire output)
- Regression: all 46 suites touched by this PR (23 inverted_index_p0, 7
fault_injection_p0, 6 variant_p0, 2 nereids_p0/show, 1 fault_injection_p2, plus
ann_index/correctness/datatype/function/insert_overwrite/nereids_arith/variant_mv)
ran against a local 1FE+1BE cluster built from this PR — **46/46 passed, 0
failed** (incl. the new `test_inverted_index_v1_deprecated`)
### Release note
Inverted index V1 is deprecated: creating new tables/indexes with
`inverted_index_storage_format = V1` (and setting it via `ADMIN SET FRONTEND
CONFIG`) is now rejected. Existing V1 tables are unaffected.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change --> New inverted index V1
creation is rejected at FE (same behavior as master after #64522).
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
