airborne12 commented on code in PR #67342:
URL: https://github.com/apache/doris/pull/67342#discussion_r3899885262
##########
regression-test/suites/fault_injection_p0/test_skip_index_compaction_fault_injection.groovy:
##########
@@ -174,12 +153,6 @@ suite("test_skip_index_compaction_fault_injection",
"nonConcurrent") {
has_update_be_config = true
check_config.call("inverted_index_compaction_enable", "true");
- try {
-
GetDebugPoint().enableDebugPointForAllBEs("Compaction::open_inverted_index_file_reader")
- run_test.call(tableName1)
- } finally {
-
GetDebugPoint().disableDebugPointForAllBEs("Compaction::open_inverted_index_file_reader")
- }
try {
Review Comment:
Checked against master: the landed version of this suite on master also has
zero occurrences of `Compaction::open_inverted_index_file_reader` — the
reader-hook removal is exactly what #64522 did upstream, and this PR ports that
hunk verbatim (byte-identical change set).
Since the resulting coverage on branch-4.1 is identical to master today,
restoring the reader hook here would make 4.1 diverge from master. The gap is
real but it is an upstream one; it should be addressed on master first and then
picked, so both branches keep the same coverage. Keeping this PR faithful to
#64522.
##########
regression-test/suites/fault_injection_p0/test_write_inverted_index_exception_fault_injection.groovy:
##########
@@ -229,7 +229,7 @@
suite("test_write_inverted_index_exception_fault_injection", "nonConcurrent") {
"InvertedIndexColumnWriter::create_unsupported_type_for_inverted_index"
]
- def inverted_index_storage_format = ["v1", "v2"]
+ def inverted_index_storage_format = ["v2"]
Review Comment:
Same situation as the reader-hook comment: I grepped the landed master
version of this suite and
`IndexFileWriter::write_v1_out_dir_createOutput_nullptr` is still present there
too (1 occurrence), i.e. #64522 left that debug point in place upstream, and
this PR ports the file's change set verbatim.
So this is not a backport-specific regression — 4.1 and master have the same
state. Removing or replacing the V1-only debug point is a valid follow-up, but
it belongs on master first so the pick keeps both branches aligned. Keeping
this PR faithful to upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
