yiguolei commented on code in PR #50290:
URL: https://github.com/apache/doris/pull/50290#discussion_r2057514869
##########
be/src/vec/sink/vtablet_block_convertor.cpp:
##########
@@ -206,10 +215,15 @@ Status OlapTableBlockConvertor::_internal_validate_column(
};
auto string_column_checker = [&](const ColumnString* column_string) {
- size_t limit = config::string_type_length_soft_limit_bytes;
+ int limit = config::string_type_length_soft_limit_bytes;
+ int len = -1;
// when type.len is negative, std::min will return overflow value, so
we need to check it
- if (type.len >= 0) {
- limit = std::min(config::string_type_length_soft_limit_bytes,
type.len);
+ if (const auto* type_str =
+
check_and_get_data_type<DataTypeString>(remove_nullable(type).get())) {
Review Comment:
我们datatype string 里保存的这个len 是什么含义？ 是最大长度的limit？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
