yiguolei commented on code in PR #50290:
URL: https://github.com/apache/doris/pull/50290#discussion_r2057510132
##########
be/src/vec/sink/vtablet_block_convertor.cpp:
##########
@@ -136,24 +140,29 @@ DecimalV2Value
OlapTableBlockConvertor::_get_decimalv2_min_or_max(const TypeDesc
}
// found
- auto iter = pmap->find({type.precision, type.scale});
+ auto iter = pmap->find(
+ {remove_nullable(type)->get_precision(),
remove_nullable(type)->get_scale()});
if (iter != pmap->end()) {
return iter->second;
}
// save min or max DecimalV2Value for next time
DecimalV2Value value;
if constexpr (is_min) {
- value.to_min_decimal(type.precision, type.scale);
+ value.to_min_decimal(remove_nullable(type)->get_precision(),
+ remove_nullable(type)->get_scale());
} else {
- value.to_max_decimal(type.precision, type.scale);
+ value.to_max_decimal(remove_nullable(type)->get_precision(),
Review Comment:
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
