yiguolei commented on code in PR #50290:
URL: https://github.com/apache/doris/pull/50290#discussion_r2057447898
##########
be/src/runtime/descriptors.cpp:
##########
@@ -334,7 +328,8 @@ void TupleDescriptor::add_slot(SlotDescriptor* slot) {
if (slot->is_materialized()) {
++_num_materialized_slots;
- if (slot->type().is_string_type() ||
slot->type().is_collection_type()) {
+ if (is_complex_type(slot->type()->get_primitive_type()) ||
+ is_string_type(slot->type()->get_primitive_type())) {
Review Comment:
bool is_string_type() const {
return type == TYPE_VARCHAR || type == TYPE_CHAR || type == TYPE_HLL
||
type == TYPE_OBJECT || type == TYPE_QUANTILE_STATE || type ==
TYPE_STRING;
}
之前type descriptor 的定义好像跟这个pr 里定义的不一样
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
