yiguolei commented on code in PR #50290:
URL: https://github.com/apache/doris/pull/50290#discussion_r2057498351
##########
be/src/vec/data_types/data_type_string.h:
##########
@@ -54,11 +49,13 @@ class DataTypeString : public IDataType {
const char* get_family_name() const override { return "String"; }
+ DataTypeString(int len = -1, PrimitiveType primitive_type =
PrimitiveType::TYPE_STRING)
Review Comment:
重构的代码，不要设置默认值，容易把一些需要改的地方漏了。
我们把默认值都删掉，确保我们看懂了所有需要改的代码。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
