yiguolei commented on code in PR #50290:
URL: https://github.com/apache/doris/pull/50290#discussion_r2057496423
##########
be/src/vec/data_types/data_type_object.h:
##########
@@ -57,9 +57,7 @@ class DataTypeObject : public IDataType {
DataTypeObject(const String& schema_format_ = "json", bool is_nullable_ =
true);
const char* get_family_name() const override { return "Variant"; }
TypeIndex get_type_id() const override { return TypeIndex::VARIANT; }
- TypeDescriptor get_type_as_type_descriptor() const override {
- return TypeDescriptor(TYPE_VARIANT);
- }
+ PrimitiveType get_primitive_type() const override { return
PrimitiveType::TYPE_VARIANT; }
Review Comment:
我们这个命名啊>...
为啥datatypeobject 对应的是variant，但是type_object 对应的是bitmap？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
