yiguolei commented on code in PR #50290:
URL: https://github.com/apache/doris/pull/50290#discussion_r2057391215
##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -472,14 +478,18 @@ bool
ScanLocalState<Derived>::_is_predicate_acting_on_slot(
}
*slot_desc = entry->second.first;
DCHECK(child_contains_slot != nullptr);
- if (child_contains_slot->type().type != (*slot_desc)->type().type ||
- child_contains_slot->type().precision !=
(*slot_desc)->type().precision ||
- child_contains_slot->type().scale != (*slot_desc)->type().scale) {
+ if (child_contains_slot->data_type()->get_primitive_type() !=
+ (*slot_desc)->type()->get_primitive_type() ||
+
vectorized::remove_nullable(child_contains_slot->data_type())->get_precision()
!=
+
vectorized::remove_nullable((*slot_desc)->type())->get_precision() ||
+
vectorized::remove_nullable(child_contains_slot->data_type())->get_scale() !=
+
vectorized::remove_nullable((*slot_desc)->type())->get_scale()) {
if (!_ignore_cast(*slot_desc, child_contains_slot.get())) {
// the type of predicate not match the slot's type
return false;
}
- } else if (child_contains_slot->type().is_datetime_type() &&
+ } else if (child_contains_slot->data_type()->get_primitive_type() ==
Review Comment:
这里为啥不remove null？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
