eldenmoon commented on code in PR #24554:
URL: https://github.com/apache/doris/pull/24554#discussion_r1378913453
##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -564,9 +564,7 @@ bool ColumnNullable::has_null(size_t size) const {
}
ColumnPtr make_nullable(const ColumnPtr& column, bool is_nullable) {
- if (is_column_nullable(*column)) {
- return column;
- }
+ if (is_column_nullable(*column) || !column->can_be_inside_nullable())
return column;
Review Comment:
!can_be_inside_nullable表明这个column一定不是nullable的。make_nullable只是调用了一下。这个一定得确保!can_be_inside_nullable是非nullable的列，否则会挂
##########
be/src/vec/columns/column_nullable.h:
##########
@@ -379,6 +384,8 @@ class ColumnNullable final : public COWHelper<IColumn,
ColumnNullable> {
ColumnPtr index(const IColumn& indexes, size_t limit) const override;
+ bool is_predicate_column() const override { return
nested_column->is_predicate_column(); }
Review Comment:
确实，我去掉
##########
be/src/vec/columns/column_nullable.h:
##########
@@ -379,6 +384,8 @@ class ColumnNullable final : public COWHelper<IColumn,
ColumnNullable> {
ColumnPtr index(const IColumn& indexes, size_t limit) const override;
+ bool is_predicate_column() const override { return
nested_column->is_predicate_column(); }
Review Comment:
确实，我去掉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
