yiguolei commented on code in PR #24554: URL: https://github.com/apache/doris/pull/24554#discussion_r1378899345
########## be/src/vec/data_types/data_type_date.h: ########## @@ -53,6 +53,10 @@ class DataTypeDate final : public DataTypeNumberBase<Int64> { TPrimitiveType::type get_type_as_tprimitive_type() const override { return TPrimitiveType::DATE; } + + doris::FieldType get_type_as_field_type() const override { Review Comment: rename to get_storage_field_type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org