eldenmoon commented on code in PR #24554:
URL: https://github.com/apache/doris/pull/24554#discussion_r1378909165
##########
be/src/vec/columns/column.h:
##########
@@ -144,6 +144,15 @@ class IColumn : public COW<IColumn> {
return nullptr;
}
+ /// Some columns may require finalization before using of other operations.
+ virtual void finalize() {}
Review Comment:
可能有的地方需要finalize不依赖object类型， 不然代码看起来略奇怪
##########
be/src/vec/columns/column.h:
##########
@@ -144,6 +144,15 @@ class IColumn : public COW<IColumn> {
return nullptr;
}
+ /// Some columns may require finalization before using of other operations.
+ virtual void finalize() {}
Review Comment:
可能有的地方需要finalize不依赖object类型， 不然代码看起来略奇怪
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
