yiguolei commented on code in PR #24554:
URL: https://github.com/apache/doris/pull/24554#discussion_r1378890928
##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -564,9 +564,7 @@ bool ColumnNullable::has_null(size_t size) const {
}
ColumnPtr make_nullable(const ColumnPtr& column, bool is_nullable) {
- if (is_column_nullable(*column)) {
- return column;
- }
+ if (is_column_nullable(*column) || !column->can_be_inside_nullable())
return column;
Review Comment:
这个函数感觉含义不对吧，这个函数预期返回的是nullable column， 这个或条件如果返回的不一定是column nullable，后续代码会挂的
##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -564,9 +564,7 @@ bool ColumnNullable::has_null(size_t size) const {
}
ColumnPtr make_nullable(const ColumnPtr& column, bool is_nullable) {
- if (is_column_nullable(*column)) {
- return column;
- }
+ if (is_column_nullable(*column) || !column->can_be_inside_nullable())
return column;
Review Comment:
这个函数感觉含义不对吧，这个函数预期返回的是nullable column， 这个或条件如果返回的不一定是column nullable，后续代码会挂的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
